Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SelectMenu): wrong placeholder color with multiple #2218

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix(SelectMenu): wrong placeholder color with multiple #2218

merged 3 commits into from
Sep 20, 2024

Conversation

malik-jouda
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Before:
Screenshot 2024-09-18 at 7 16 10 PM
After:
Screenshot 2024-09-18 at 7 18 15 PM

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@malik-jouda malik-jouda changed the title Bug fix fix(SelectMenu): wrong placeholder color when modelValue is an empty (string/array) Sep 18, 2024
@benjamincanac benjamincanac changed the title fix(SelectMenu): wrong placeholder color when modelValue is an empty (string/array) fix(SelectMenu): wrong placeholder color with multiple Sep 20, 2024
@benjamincanac benjamincanac merged commit 28ad5cf into nuxt:dev Sep 20, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

@malik-jouda malik-jouda deleted the bug-fix branch September 20, 2024 19:22
patrick-hofmann pushed a commit to patrick-hofmann/nuxt-ui that referenced this pull request Oct 3, 2024
@malik-jouda @patrick-hofmann
fix(SelectMenu): wrong placeholder color with multiple (nuxt#2218)
b877ab9
@FroudeDescartes FroudeDescartes mentioned this pull request Oct 30, 2024
Closed
@numselli numselli mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malik-jouda @benjamincanac